Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): ensure that the correct focus and hover styling is applied to popover-container button - FE-7061 #7194

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

DipperTheDan
Copy link
Contributor

@DipperTheDan DipperTheDan commented Feb 6, 2025

Proposed behaviour

Hover styling in Safari:
Screenshot 2025-02-06 at 16 40 16

Focus and hovered styling in Safari:
Screenshot 2025-02-06 at 16 41 32

Current behaviour

Less than ideal styling currently in Safari:
Screenshot 2025-02-06 at 16 41 03

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

Using Safari:

  • Navigate to Menu -> Test -> as link with alternate variant.
  • Click and hover over the Notification menu-item.
  • Focus styling and hover styling should be correctly applied.

On all browsers:

  • Check that no regressions have occurred to any button styling in menu-items.

@DipperTheDan DipperTheDan self-assigned this Feb 6, 2025
@DipperTheDan DipperTheDan requested review from a team as code owners February 6, 2025 16:43
@DipperTheDan DipperTheDan marked this pull request as draft February 7, 2025 09:10
@tomdavies73 tomdavies73 marked this pull request as ready for review February 7, 2025 10:43
@tomdavies73 tomdavies73 self-requested a review February 7, 2025 10:48
@tomdavies73 tomdavies73 marked this pull request as draft February 7, 2025 10:51
@DipperTheDan DipperTheDan force-pushed the FE-7061_popover-container-safari-styling-bug branch from eb2c4d2 to e9372a6 Compare February 7, 2025 15:03
@DipperTheDan DipperTheDan marked this pull request as ready for review February 7, 2025 15:04
@DipperTheDan DipperTheDan merged commit 1bf0530 into master Feb 10, 2025
28 checks passed
@DipperTheDan DipperTheDan deleted the FE-7061_popover-container-safari-styling-bug branch February 10, 2025 15:22
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 147.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants